Archive for feature envy

Second-class citizens above the law

Posted in Design Issues with tags , , , , , on January 13, 2010 by moffdub

It’s not too late. Almost eleven months have passed since I favored a Long Parameter List over perceived Feature Envy on the grounds of coupling with the order of the parameters:

Long Parameter Lists are also about coupling, to a lesser extent. You are coupled to the order of the parameters.

I even said in that post that Feature Envy isn’t a clear-cut issue:

Let me share something about Tell Don’t Ask that I’ve realized: the most harmful instances that require attention are those where you get some values out of an object, do something with them, and set some others back into the object.

Yes. And then I defended the readability of a Long Parameter List:

Continue reading

Feature Envy vs. Long Parameter List

Posted in Design Issues with tags , , , , on February 18, 2009 by moffdub

Why is there always something wrong with code? I can’t make one improvement without sacrificing something else.

I’m not talking about trades between coupling and performance, understandability and speed. Tackle one code smell and you’ve just introduced another, a sick game of Whack-A-Mole.

Continue reading

Follow

Get every new post delivered to your Inbox.